Title : ADS - Conflict between sections PDR Reference: 99120002 Originator Reference: - SARPs Document Reference: ADS SARPs, sections 2.2.1.5.3.4.5 and 2.2.1.5.3.15.4. Status: ADOPTED Impact: C PDR Revision Date: 30/01/02 (RESOLVED -> ADOPTED) 25/08/00 (PROPOSED -> RESOLVED) 14/08/00 (ACCEPTED -> PROPOSED) 04/04/00 (SUBMITTED -> ACCEPTED) PDR Submission Date: 29/12/99 Submitting State/Organization: ACI/ASE Submitting Author Name: Gilles BLANC / Shawn Stokes Submitting Author E-mail Address: Gilles.Blanc@sextant.thomson-csf.com / Shawn.Stokes@ATNSI.COM Submitting Author Supplemental Contact Information: SARPs Date: ICAO 9705 Edition 2 and Edition 3 SARPs Language: English Summary of Defect: Two paragraphs are in conflicts. One paragraph stipulates that, under certain circumstances, primitives entering the ASE needs to be rejected (section 2.2.1.5.3.4.5). Another paragraph assumes that some primitives have entered the ASE, and provides a description of operations to be performed (sections 2.2.1.5.3.15.4, 2.2.1.5.3.15.4.1 and 2.2.1.5.3.15.4.2). This results in branches of code which can never be exerciced (dead code). The two sets of paragraphs are inserted herebelow: -------------------------------------------------------- 2.2.1.5.3.4.5 The ground HI module shall reject requests and responses, apart from ADS-user-abort requests, when the ground LI module is in the LI-G-START state or the LI-G-END state. -------------------------------------------------------- 2.2.1.5.3.15.4 Upon receipt of an ADS-cancel-contract-PDU, ADS-modify-emergency-contract-PDU, or ADS-cancel-emergency-acknowledgement-PDU from the ground DC, EC, PC or EM modules: 2.2.1.5.3.15.4.1 If in the LI-G-ACTIVE state, the ground LI module shall: a) invoke D-DATA req with the PDU in the user data, b) if the DC module is in the DC-G-IDLE state, and the EC module is in the EC-G-IDLE state, and the PC module is in the PC-G-IDLE state, and the ground EM module is in the EM-G-IDLE state, then: 1) invoke D-END req with no user data 2) start the t-LI-1 timer, and 3) enter the LI-G-END state; or c) otherwise, remain in the LI-G-ACTIVE state. 2.2.1.5.3.15.4.2 If in the LI_G_END state, the ground LI module shall remain in the LI_G_END state. -------------------------------------------------------- The first paragraph (section 2.2.1.5.3.4.5) stipulates that ADS-cancel-contract-PDU, ADS-modify-emergency-contract-PDU are to be rejected by HI when LI is in LI-G-END state. The second (section 2.2.1.5.3.15.4.2) provides a description of actions to be performed by LI, upon receipt of these primitives (which cannot be received by LI, because HI is not allowed to process them internally to the ASE). This results of useless and untestable code. Note that this section is still valid upon receipt from the EM module of an ADS-cancel-emergency-acknowledgement-PDU when the LI module is already in the LI-G-END state (see figure 28). Assigned SME: Sub-Volume II SME Proposed SARPs amendment: The proposal is to restrict the scope of section 2.2.1.5.3.15.4.2, in order not to be in conflict in the case of ADS-cancel-contract-PDU, ADS-modify-emergency-contract-PDU requests (section 2.2.1.5.3.4.5 and 2.2.1.5.3.15.4.1 are left unchanged). 1/ Change section 2.2.1.5.3.15.4.2 from: 2.2.1.5.3.15.4.2 If in the LI-G-END state, the ground LI module shall remain in the LI-G-END state. To: 2.2.1.5.3.15.4.2 Upon receipt of an ADS-cancel-emergency-acknowledgement-PDU from the EM module and if in the LI-G-END state, the ground LI module shall remain in the LI_G_END state. Impact on interoperability: None, since this PDR removes from the SARPs some requirements which are never exercised anyway. Implementations fixing the defect continue to interoperate with previous implementations. SME Recommendation to CCB: - CCB decision: atnp_ccb_chair: SUBMITTED (05/01/00) atnp_ccb_chair: ACCEPTED (04/04/00) atnp_ccb_chair: PROPOSED (14/08/00) CCB-12 (Berlin): RESOLVED (25/08/00)